GD - backport fix for libpng warning when loading interlaced images #8002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2022
|
This would be an upstream issue, so please provide a PR there. After it has been fixed there, the patch can be backported to the bundled libgd. |
|
Submitted to libgd now libgd/libgd#823 Will you merge this PR once it has been applied to libgd, or will I need to submit a new PR at that point? |
|
We can merge this PR, or backport the libgd commit later; doesn't really matter. :) |
brettwhiteman
changed the title
|
@cmb69 The upstream PR has been merged and I've updated this PR to match 🙂 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a warning is being generated when reading interlaced PNGs due to libpng being used incorrectly.
Refer to https://github.com/glennrp/libpng/blob/libpng16/pngread.c#L727 for the source of this warning.
This PR enables the interlacing transform prior to calling
png_read_update_info()to prevent this warning. There is no change in functionality since libpng automatically does this after emitting the warning anyway.